dion/HA-Shopping-List-Manager
1
0
Fork 0
mirror of https://github.com/thekiwismarthome/shopping-list-manager.git synced 2026-08-30 11:34:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: reuse cached search engine instead of rebuilding on every query

Browse Source 
search_products() and find_product_substitutes() were ignoring the
already-built self._search_engine and creating a brand new ProductSearch
instance on every call — serialising every product to dict and
re-initialising the fuzzy engine each time.

They now use self._search_engine directly. The engine is already kept
up-to-date by add_product / update_product / delete_product, so no
correctness change is needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
thekiwismarthome
2026-08-11 17:45:43 +12:00
parent c55e90d74f
commit 91cbc6018c
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
custom_components/shopping_list_manager/storage.py
+2 -10
View File
@@ -519,11 +519,7 @@ class ShoppingListStorage:
_LOGGER.warning("Search engine not initialized") _LOGGER.warning("Search engine not initialized")
return [] return []
# Convert products dict to format search engine expects results = self._search_engine.search(
products_dict = {pid: p.to_dict() for pid, p in self._products.items()}
search_engine = ProductSearch(products_dict)
results = search_engine.search(
query=query, query=query,
limit=limit, limit=limit,
exclude_allergens=exclude_allergens, exclude_allergens=exclude_allergens,
@@ -531,7 +527,6 @@ class ShoppingListStorage:
substitution_group=substitution_group, substitution_group=substitution_group,
) )
# Convert back to Product objects
return [self._products[r["id"]] for r in results if r["id"] in self._products] return [self._products[r["id"]] for r in results if r["id"] in self._products]
def find_product_substitutes(self, product_id: str, limit: int = 5) -> List[Product]: def find_product_substitutes(self, product_id: str, limit: int = 5) -> List[Product]:
@@ -547,10 +542,7 @@ class ShoppingListStorage:
if not self._search_engine: if not self._search_engine:
return [] return []
products_dict = {pid: p.to_dict() for pid, p in self._products.items()} results = self._search_engine.find_substitutes(product_id, limit)
search_engine = ProductSearch(products_dict)
results = search_engine.find_substitutes(product_id, limit)
return [self._products[r["id"]] for r in results if r["id"] in self._products] return [self._products[r["id"]] for r in results if r["id"] in self._products]
def get_product_suggestions(self, limit: int = 20) -> List[Product]: def get_product_suggestions(self, limit: int = 20) -> List[Product]: